Skip to content

ensure copyright banner survives minification#5682

Merged
perliedman merged 1 commit intoLeaflet:masterfrom
jgravois:banner
Aug 6, 2017
Merged

ensure copyright banner survives minification#5682
perliedman merged 1 commit intoLeaflet:masterfrom
jgravois:banner

Conversation

@jgravois
Copy link
Copy Markdown

@jgravois jgravois commented Aug 2, 2017

v1.1.0 is missing the copyright banner.

adding @preserve (and --comments in the uglify CLI command) resolves the problem.

prior to making this patch i encountered an unrelated error:

$ uglifyjs --version
uglify-js 3.0.27

$ npm run uglify

> leaflet@1.1.0 uglify /Users/john/github/Leaflet
> uglifyjs dist/leaflet-src.js -c -m -o dist/leaflet.js --source-map dist/leaflet.js.map --in-source-map dist/leaflet-src.js.map --source-map-url leaflet.js.map

Supported options:
  content         null
  filename        null
  includeSources  false
  root            null
  url             null
ERROR: `dist/leaflet.js.map` is not a supported option

substituting filename=dist/leaflet.js.map took care of that as well.

Copy link
Copy Markdown
Member

@perliedman perliedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great catches both of them.

@perliedman perliedman merged commit 567f13a into Leaflet:master Aug 6, 2017
@jgravois jgravois deleted the banner branch August 6, 2017 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants