enable to pass simple array form to the method setBounds#5687
Merged
perliedman merged 1 commit intoLeaflet:masterfrom Aug 5, 2017
ronikar:fix-ImageOverlay-setBounds
Merged
enable to pass simple array form to the method setBounds#5687perliedman merged 1 commit intoLeaflet:masterfrom ronikar:fix-ImageOverlay-setBounds
perliedman merged 1 commit intoLeaflet:masterfrom
ronikar:fix-ImageOverlay-setBounds
Conversation
perliedman
approved these changes
Aug 5, 2017
Member
perliedman
left a comment
perliedman
left a comment
There was a problem hiding this comment.
Nice catch! This is indeed an oversight in the implementation. Thanks for fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not really sure if it's bug or not. In your docs to create imageOverlay I can to pass bounds as simple array. However the function setBounds work only when it gets L.LatLngBounds, It's not work with simple array. so, I change the logic of this function in order to enable to pass simple array to this function.