Skip to content

Conversation

@FredrikTaquist
Copy link
Collaborator

The following code

		for (ShortPrefix u : shorts) {
			if (!(u instanceof ShortPrefix)) {
				leaves.get(u).elevatePrefix(u, oracle, inputs);
			}
		}

in the method CTInnerNode#refine does not do anything since it will never be the case that u is not an instance of ShortPrefix. The intent is to make sure that prefixes which are short remain short after being sifted into the classification tree following refinement. Since this is already handled by ClassificationTree#refine, it is not necessary to have that check here. This PR therefore removes the code.

@kostis
Copy link
Collaborator

kostis commented Jan 28, 2026

LGTM.

@kostis kostis merged commit c607431 into main Jan 28, 2026
4 checks passed
@kostis kostis deleted the remove-dead-code branch January 28, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants