Skip to content

fix(desktop): mark wallet v4 tour as seen at onboarding start#15051

Open
cfloume wants to merge 1 commit intodevelopfrom
fix/LIVE-27171/onboarding-wv4-tour-display-logic
Open

fix(desktop): mark wallet v4 tour as seen at onboarding start#15051
cfloume wants to merge 1 commit intodevelopfrom
fix/LIVE-27171/onboarding-wv4-tour-display-logic

Conversation

@cfloume
Copy link
Contributor

@cfloume cfloume commented Mar 4, 2026

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
    • No new automated test added for this small hook wiring change.
  • Impact of the changes:
    • Users who enter onboarding on desktop will now have hasSeenWalletV4Tour set at onboarding start, so the Wallet V4 Tour dialog does not auto-open after onboarding.
    • Applies to both WelcomeNew and WelcomeOld onboarding variants.
    • Includes the lazy onboarding path (user reaches dashboard first, then onboards a device later).

📝 Description

This fixes a desktop parity gap with mobile for Wallet V4 Tour behavior.

A new desktop hook (useMarkWalletV4TourSeenAtOnboardingStart) now dispatches setHasSeenWalletV4Tour(true) on onboarding welcome mount, and the hook is called from the shared onboarding Welcome entry component. This ensures users who go through onboarding are not shown the Wallet V4 Tour afterward.

A changeset is included for ledger-live-desktop.

❓ Context

  • JIRA or GitHub link: LIVE-27171

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Made with Cursor

@cfloume cfloume requested a review from a team as a code owner March 4, 2026 16:29
Copilot AI review requested due to automatic review settings March 4, 2026 16:29
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Mar 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

⚠️ E2E tests are required

Changes detected require e2e testing before merge (even before asking for any review).

🖥️ Desktop

-> Run Desktop E2E

  • Select "Run workflow"
  • Branch: fix/LIVE-27171/onboarding-wv4-tour-display-logic
  • Device: nanoSP or stax

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Ledger Live Desktop onboarding so that entering the onboarding flow marks the Wallet V4 Tour as “seen”, preventing the tour dialog from auto-opening after onboarding (aligning behavior with mobile).

Changes:

  • Call a new hook from the shared onboarding Welcome entry component to set hasSeenWalletV4Tour at onboarding start.
  • Add useMarkWalletV4TourSeenAtOnboardingStart MVVM hook that dispatches setHasSeenWalletV4Tour(true) on mount.
  • Add a desktop changeset for the patch release.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
apps/ledger-live-desktop/src/renderer/components/Onboarding/Screens/Welcome/index.tsx Wires the new hook into onboarding entry so both Welcome variants trigger the “seen” flag.
apps/ledger-live-desktop/src/mvvm/features/WalletV4Tour/hooks/useMarkWalletV4TourSeenAtOnboardingStart.ts Introduces a hook that dispatches setHasSeenWalletV4Tour(true) when onboarding starts.
.changeset/four-masks-tease.md Declares a patch changeset for the desktop fix.

Comment on lines +9 to +14
export function useMarkWalletV4TourSeenAtOnboardingStart(): void {
const dispatch = useDispatch();

useEffect(() => {
dispatch(setHasSeenWalletV4Tour(true));
}, [dispatch]);
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new MVVM hook introduces user-facing behavior but has no automated test. Please add a unit test (e.g., via renderHook with a test store) asserting that mounting the hook dispatches setHasSeenWalletV4Tour(true) / updates settings.hasSeenWalletV4Tour (and ideally that it only dispatches once per mount).

Copilot generated this review using guidance from repository custom instructions.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Has changes in LLD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants