fix(desktop): mark wallet v4 tour as seen at onboarding start#15051
fix(desktop): mark wallet v4 tour as seen at onboarding start#15051
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR updates Ledger Live Desktop onboarding so that entering the onboarding flow marks the Wallet V4 Tour as “seen”, preventing the tour dialog from auto-opening after onboarding (aligning behavior with mobile).
Changes:
- Call a new hook from the shared onboarding
Welcomeentry component to sethasSeenWalletV4Tourat onboarding start. - Add
useMarkWalletV4TourSeenAtOnboardingStartMVVM hook that dispatchessetHasSeenWalletV4Tour(true)on mount. - Add a desktop changeset for the patch release.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/ledger-live-desktop/src/renderer/components/Onboarding/Screens/Welcome/index.tsx | Wires the new hook into onboarding entry so both Welcome variants trigger the “seen” flag. |
| apps/ledger-live-desktop/src/mvvm/features/WalletV4Tour/hooks/useMarkWalletV4TourSeenAtOnboardingStart.ts | Introduces a hook that dispatches setHasSeenWalletV4Tour(true) when onboarding starts. |
| .changeset/four-masks-tease.md | Declares a patch changeset for the desktop fix. |
| export function useMarkWalletV4TourSeenAtOnboardingStart(): void { | ||
| const dispatch = useDispatch(); | ||
|
|
||
| useEffect(() => { | ||
| dispatch(setHasSeenWalletV4Tour(true)); | ||
| }, [dispatch]); |
There was a problem hiding this comment.
This new MVVM hook introduces user-facing behavior but has no automated test. Please add a unit test (e.g., via renderHook with a test store) asserting that mounting the hook dispatches setHasSeenWalletV4Tour(true) / updates settings.hasSeenWalletV4Tour (and ideally that it only dispatches once per mount).
|



✅ Checklist
npx changesetwas attached.hasSeenWalletV4Tourset at onboarding start, so the Wallet V4 Tour dialog does not auto-open after onboarding.WelcomeNewandWelcomeOldonboarding variants.📝 Description
This fixes a desktop parity gap with mobile for Wallet V4 Tour behavior.
A new desktop hook (
useMarkWalletV4TourSeenAtOnboardingStart) now dispatchessetHasSeenWalletV4Tour(true)on onboarding welcome mount, and the hook is called from the shared onboardingWelcomeentry component. This ensures users who go through onboarding are not shown the Wallet V4 Tour afterward.A changeset is included for
ledger-live-desktop.❓ Context
🧐 Checklist for the PR Reviewers
Made with Cursor