Reduce executive TCP retransmit noise from minimal flows#1046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR addresses issue #1033 by reducing retransmit noise in executive / queue-dynamics summary heatmaps caused by very small TCP samples.
What Changed
tcp_packets >= 100retransmits >= 2Noneinstead of being colored as0%or a noisy retransmit percentage.Scope
This change applies only to summary heatmap paths:
Detailed circuit and per-flow retransmit drill-down data is unchanged.
Implementation Details
Tests
Added focused coverage for the three backend summary paths:
Validation
cargo fmt --allcargo test -p lqos_utils temporal_heatmap -- --nocapturecargo test -p lqos_config network_json::test::site_heatmap -- --nocapturecargo test -p lqosd throughput_tracker::tracking_data::tests::circuit_and_global_heatmaps -- --nocapturecargo test -p lqosd throughput_tracker::flow_data::asn_heatmap::tests -- --nocapturecargo check -p lqos_config -p lqosdcargo clippy -p lqos_config --all-targets -- -D warningscargo clippy -p lqosd --all-targets -- -D warningsFollow-Up Not In This PR