fix: prebuild by adding full src dir#2074
Open
CrazyWolf13 wants to merge 1 commit intoLissy93:masterfrom
Open
Conversation
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lissy93
reviewed
Apr 16, 2026
Owner
Lissy93
left a comment
Lissy93
left a comment
There was a problem hiding this comment.
I don't think this would work still :/
Because rebuild endpoint needs the dev assets
There's 2 options:
- Wait till the newer version is merged, and I'll try and reduce the reliance on any client-side env vars, so none of the rebuild functionality will be needed
- Or, bundle all of the dev stuff in here too, which seems messy and will make everything much larger.
I'd go with option 1. Rebuilding is really ugly, and I want to fully remove any need for it.
Collaborator
Author
|
Installing without I guess I'll leave this up to you to decide then, so feel free to close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Bugfix
Overview
Small changes to fix the built-in compile button. Users reported it as working before, but seems like it didn't :D
Now it seems to be fully working:
Issue Number
Additional Info