Skip to content

Source gen maps#1998

Merged
beto-rodriguez merged 17 commits intodevfrom
source-gen-maps
Sep 25, 2025
Merged

Source gen maps#1998
beto-rodriguez merged 17 commits intodevfrom
source-gen-maps

Conversation

@beto-rodriguez
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the LiveCharts codebase to implement a source generation approach for map charts across multiple UI frameworks. The changes introduce generated code for GeoMap components, consolidate common functionality, and create a new IDrawnView interface to share drawing-related properties between chart and map views.

Key changes:

  • Introduces a source generation approach for map chart components
  • Creates IDrawnView interface to extract common drawing properties from IChartView
  • Refactors existing chart implementations to use the new interface hierarchy

Reviewed Changes

Copilot reviewed 42 out of 42 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
Multiple platform GeoMap.cs files Simplified to inherit from generated base classes instead of implementing full functionality
Generated SourceGenMapChart files New source-generated base classes providing platform-specific map chart implementations
IDrawnView.cs New interface extracting common drawing properties (CoreCanvas, ControlSize)
IChartView.cs Refactored to inherit from IDrawnView instead of defining drawing properties directly
Various platform-specific files Updated to reference IDrawnView properties instead of IChartView properties

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

beto-rodriguez and others added 6 commits September 25, 2025 13:55
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…Code/SourceGenMapChart.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ratedCode/SourceGenSKMapChart.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants