Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the LiveCharts codebase to implement a source generation approach for map charts across multiple UI frameworks. The changes introduce generated code for GeoMap components, consolidate common functionality, and create a new IDrawnView interface to share drawing-related properties between chart and map views.
Key changes:
- Introduces a source generation approach for map chart components
- Creates
IDrawnViewinterface to extract common drawing properties fromIChartView - Refactors existing chart implementations to use the new interface hierarchy
Reviewed Changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
Multiple platform GeoMap.cs files |
Simplified to inherit from generated base classes instead of implementing full functionality |
Generated SourceGenMapChart files |
New source-generated base classes providing platform-specific map chart implementations |
IDrawnView.cs |
New interface extracting common drawing properties (CoreCanvas, ControlSize) |
IChartView.cs |
Refactored to inherit from IDrawnView instead of defining drawing properties directly |
| Various platform-specific files | Updated to reference IDrawnView properties instead of IChartView properties |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/skiasharp/LiveChartsCore.SkiaSharp.WinForms/LiveChartsGeneratedCode/SourceGenChart.cs
Show resolved
Hide resolved
src/skiasharp/LiveChartsCore.SkiaSharp.WPF/LiveChartsGeneratedCode/SourceGenMapChart.cs
Outdated
Show resolved
Hide resolved
src/skiasharp/LiveChartsCore.SkiaSharp/SKCharts/LiveChartsGeneratedCode/SourceGenSKMapChart.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…Code/SourceGenMapChart.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ratedCode/SourceGenSKMapChart.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced Apr 2, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.