Conversation
Thanks for your contribution! 🤗 (1 / 4)The build and test process is starting. This may take a while. Packing complete! 📦 (2 / 4)You can download the NuGet packages for this build here. Running tests 🧪 (3 / 4)Tests are running now, you can monitor their progress below or at the actions tab. Core ✅ | Snapshot ✅ | Windows ✅ | Linux ✅ | Mac ✅ | Browser ✅ | Android ✅ | iOS ✅ Test Results Summary (Passed) ✅ (4 / 4) |
There was a problem hiding this comment.
Pull request overview
This PR removes previously commented-out guidance/workarounds in sample projects and re-enables the corresponding XAML styling now that the samples appear to be targeting updated platform/tooling (notably Uno SDK).
Changes:
- Re-enabled previously commented XAML styling by using nested markup extensions (e.g.,
Frame→SolidColorPaint,SolidColorPaint→Dashed) across multiple WinUI sample views. - Updated
UnoPlatformSampleto a newerUno.Sdkversion and added a build warning suppression. - Removed per-view font/typeface configuration snippets from WinForms/EtoForms
LabelsFormat2samples.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/WinUISample/WinUISample/Samples/StepLines/Area/View.xaml | Enables DrawMarginFrame using nested markup extensions. |
| samples/WinUISample/WinUISample/Samples/Lines/Padding/View.xaml | Enables DrawMarginFrame using nested markup extensions. |
| samples/WinUISample/WinUISample/Samples/Lines/Area/View.xaml | Enables DrawMarginFrame using nested markup extensions. |
| samples/WinUISample/WinUISample/Samples/General/Sections2/View.xaml | Enables section stroke styling with nested Dashed path effect. |
| samples/WinUISample/WinUISample/Samples/Design/StrokeDashArray/View.xaml | Enables dashed stroke styling via nested markup extensions. |
| samples/WinUISample/WinUISample/Samples/Axes/Style/View.xaml | Enables chart/axis styling using nested markup extensions (frame + dashed separators). |
| samples/WinUISample/WinUISample/Samples/Axes/MatchScale/View.xaml | Enables DrawMarginFrame using nested markup extensions. |
| samples/WinFormsSample/Axes/LabelsFormat2/View.cs | Removes non-Latin font registration snippet from the view constructor. |
| samples/EtoFormsSample/Axes/LabelsFormat2/View.cs | Removes non-Latin font registration snippet from the view constructor. |
| samples/UnoPlatformSample/UnoPlatformSample/UnoPlatformSample.csproj | Bumps Uno.Sdk and suppresses MSB4240. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.