Skip to content

ci(codeql): enable for github actions#448

Merged
ReenigneArcher merged 1 commit intomasterfrom
ci/codeql/enable-for-github-actions
Apr 25, 2025
Merged

ci(codeql): enable for github actions#448
ReenigneArcher merged 1 commit intomasterfrom
ci/codeql/enable-for-github-actions

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Apr 24, 2025

Description

Add "actions" for CodeQL scanning.

Note: CodeQL flagged every workflow for not having "permissions" set explicitly. Hopefully none of the workflows break with what I have set, but might have a few surprises after the PRs are created in each repo.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@ReenigneArcher ReenigneArcher force-pushed the ci/codeql/enable-for-github-actions branch 2 times, most recently from 185efd9 to 7765f72 Compare April 25, 2025 00:42
@ReenigneArcher ReenigneArcher force-pushed the ci/codeql/enable-for-github-actions branch from 7765f72 to 37a7a44 Compare April 25, 2025 03:17
@sonarqubecloud
Copy link

@ReenigneArcher ReenigneArcher requested a review from Copilot April 25, 2025 03:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates multiple GitHub Actions workflow files to explicitly set permissions and expand event-type configurations, in order to comply with CodeQL scanning requirements and recent best practices.

  • Explicitly set permissions (e.g. contents: read or empty permissions) in all workflow files
  • Expand inline arrays for event types (release, issues, etc.)
  • Refactor conditional expressions and rename some job steps to improve clarity

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/update-docs.yml Added explicit permissions and expanded release event types
.github/workflows/update-changelog.yml Added permissions, updated event types, and renamed job for clarity
.github/workflows/social-post.yml Adjusted conditional expressions in if clauses
.github/workflows/renovate-config-validator.yml Updated branch and types syntax with explicit permissions
.github/workflows/release-notifier.yml Added permissions and refined conditional expressions
.github/workflows/patch_missing_releases.yml Added permissions configuration
.github/workflows/issues.yml Added explicit permissions and expanded issue event types
.github/workflows/issues-stale.yml Added permissions, updated job naming, and refined conditions
.github/workflows/global-replicator.yml Added permissions and adjusted branch filtering
.github/workflows/common-lint.yml Added explicit permissions and simplified a log step
.github/workflows/codeql.yml Added permissions, refined branch filters, and updated matrix generation
.github/workflows/cla-gist-replicator.yml Added permissions and adjusted branch filtering
.github/workflows/ci-docker.yml Added permissions, refined trigger conditions, and updated job structure
Comments suppressed due to low confidence (1)

.github/workflows/ci-docker.yml:130

  • [nitpick] Consider adding a separator between 'Docker' and the tag value (e.g. 'Docker - ${{ matrix.tag }}') for improved readability.
name: Docker${{ matrix.tag }}

@ReenigneArcher ReenigneArcher merged commit a8c37b6 into master Apr 25, 2025
13 checks passed
@ReenigneArcher ReenigneArcher deleted the ci/codeql/enable-for-github-actions branch April 25, 2025 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.github: scan GitHub actions with CodeQL

1 participant