feat: flip binary operator check if failed (#2777)#2779
Merged
sumneko merged 3 commits intoLuaLS:masterfrom Aug 6, 2024
Merged
feat: flip binary operator check if failed (#2777)#2779sumneko merged 3 commits intoLuaLS:masterfrom
sumneko merged 3 commits intoLuaLS:masterfrom
Conversation
if vm.runOperator fails try again with flipped arguments this emulates how lua checks the binary metaevents in which if there is no corresponding binary metaevent for the left operand it checks the right operand instead. This also works when both operands are tables. This change affects: - __add - __sub - __mul - __div - __idiv - __mod - __pow - __concat - __band - __bor - __bxor - __shl - __shr
bc46110 to
8635fef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2777
if vm.runOperator fails try again with flipped arguments
this emulates how lua checks the binary metaevents in which
if there is no corresponding binary metaevent for the left
operand it checks the right operand instead. This also works
when both operands are tables.
example case:
This change affects:
Credit to tomlau10 for preliminary code