Skip to content

Feature/901 ignorePath option in EG for functions is no longer required#1028

Merged
kolbinski merged 2 commits intomasterfrom
feature/901-ignorepath-option-in-eg-for-function-is-no-longer-required
Oct 26, 2018
Merged

Feature/901 ignorePath option in EG for functions is no longer required#1028
kolbinski merged 2 commits intomasterfrom
feature/901-ignorepath-option-in-eg-for-function-is-no-longer-required

Conversation

@kolbinski
Copy link
Contributor

connect #901

@DrMegavolt
Copy link
Contributor

waiting for fix in kubeless

@DrMegavolt
Copy link
Contributor

PR in kubeless vmware-archive/kubeless#928

@kolbinski can you verify for Python 3.6 that my custom build image works as expected if you remove ignorePath flag. Works on my side

import json
def fn(event, context):
    print(event)
    return "URL = " +  event['extensions']['request'].path

@kolbinski
Copy link
Contributor Author

Works ok. When I execute http://gateway-ko-dev.staging.lunchbadger.io/myfunction1?a=b the output is URL = /myfunction1 but I guess it's expected.

@DrMegavolt
Copy link
Contributor

vmware-archive/kubeless#928 is now merged so we can go forward and merge this one.
FYI:
use return "URL = " + event['extensions']['request'].url to get full url with query params.

python 3.6 and 2.7 runtimes updated on staging

@kolbinski kolbinski merged commit 22d9cc5 into master Oct 26, 2018
@kolbinski kolbinski deleted the feature/901-ignorepath-option-in-eg-for-function-is-no-longer-required branch October 26, 2018 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants