Skip to content

fix: wrong event register#106

Merged
lonelyicer merged 2 commits intomainfrom
fix/client-setup-event
Feb 13, 2026
Merged

fix: wrong event register#106
lonelyicer merged 2 commits intomainfrom
fix/client-setup-event

Conversation

@lonelyicer
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings February 13, 2026 12:35
@github-actions
Copy link

github-actions bot commented Feb 13, 2026

Game Test Results

✅ Success

Metric Value
Total Tests 1
Passed 1
Failed 0
Duration 384.6 ms

Workflow run: #368

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes an incorrect event registration pattern for the FMLClientSetupEvent handler. The event handler was previously using the @SubscribeEvent annotation in the MIAClient class, which is the wrong pattern for mod bus events in NeoForge. The fix moves the handler to MiaClientEvents and registers it properly using modEventBus.addListener.

Changes:

  • Moved onClientSetup event handler from MIAClient to MiaClientEvents class
  • Changed event registration from @SubscribeEvent annotation to modEventBus.addListener pattern
  • Reorganized imports to reflect the moved functionality

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/main/java/com/altnoir/mia/client/MIAClient.java Removed incorrect @SubscribeEvent handler and added proper listener registration via modEventBus.addListener
src/main/java/com/altnoir/mia/client/MiaClientEvents.java Added the onClientSetup method and necessary imports for handling FMLClientSetupEvent

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lonelyicer lonelyicer enabled auto-merge February 13, 2026 12:50
@lonelyicer lonelyicer merged commit 6d8597e into main Feb 13, 2026
3 checks passed
@lonelyicer lonelyicer deleted the fix/client-setup-event branch March 16, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants