Merged
Conversation
Game Test Results✅ Success
Workflow run: #413 |
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the language data generation flow by moving a set of “default” translations into resource JSON files and generating additional translations (biomes/paintings, items/blocks, stats, potions) programmatically during datagen.
Changes:
- Added
assets/mia/lang/default/*.jsonfiles and updatedMiaLangProviderto load them duringaddTranslations(). - Added
FilesHelperJSON loader utility and switchedMiaLangProviderto use it. - Introduced tracking lists in
MiaBiomesandMiaPaintingVariantsto auto-generate biome/painting translations.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/main/resources/assets/mia/lang/default/tooltip.json |
New default tooltip translation source used by datagen. |
src/main/resources/assets/mia/lang/default/ponder.json |
New (currently empty) default translation source loaded by datagen. |
src/main/resources/assets/mia/lang/default/interface.json |
New default UI/config/attribute/etc translation source used by datagen. |
src/main/java/com/altnoir/mia/worldgen/biome/MiaBiomes.java |
Adds a list of biome keys populated during biome bootstrap to support lang generation. |
src/main/java/com/altnoir/mia/util/FilesHelper.java |
Adds a helper to load/parse JSON resources from the classpath. |
src/main/java/com/altnoir/mia/init/MiaPaintingVariants.java |
Adds a list of painting variant keys populated during bootstrap to support lang generation. |
src/main/java/com/altnoir/mia/datagen/MiaLangProvider.java |
Loads default lang fragments from resources and auto-generates biome/painting + registry-based translations. |
src/main/java/com/altnoir/mia/datagen/MiaBiomeTagsProvider.java |
Minor signature/annotation update. |
src/generated/resources/data/mia/tags/item/artifact_modifiers_material.json |
Reorders tag values. |
src/generated/resources/assets/mia/lang/en_us.json |
Regenerated lang output reflecting the provider refactor and updated keys/values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.