Add linting of SQL files using sqlfluff #1480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is primarily to ensure the convert to PostgreSQL shell script continues to work by allowing long file lines.
tompollard
reviewed
Feb 13, 2023
Member
tompollard
left a comment
tompollard
left a comment
There was a problem hiding this comment.
Good to know about this linter!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a package for linting SQL files called sqlfluff (GitHub link).
I've added a rule file using the simplest core rules plus L019 which enforces leading commas. Importantly, this PR has no functional changes, and only the application of
sqlfluff fixto themimic-iv/conceptssubfolder. Further, some rules were skipped on a file-specific level to ensure that the conversion to PostgreSQL scripts would still work.I've also added a GitHub action which should verify that files are appropriately linted on a PR and annotate errors if they are found. Haven't tested it yet though, so here goes nothing :)