Remove unnecessary pass

[gtrevisan]

address:

• W0107 @ https://pylint.pycqa.org/en/latest/user_guide/messages/warning/unnecessary-pass.html / ruff

test with:

make pylint-only CODE=W0107

fixed with:

poetry run ruff check --fix disruption_py examples tests --select PIE790

[yumouwei]

Should it raise a NotImplementedError?

[gtrevisan]

I think all of these passes are unnecessary simply because the docstrings make the functions well-defined.
it does not do anything with or without the pass.
another thing is changing the logic, but I believe the passes here are proper because this is just a declaration of the necessary methods that need to be overridden by any subclass.
hopefully Amos will confirm once he gets to this.

[amdecker]

Yeah exactly -- we can remove the passes & leave the body empty of everything except the docstring because all the logic is implemented by subclasses.

[amdecker]

Looks like there's a few more in the drafts/ folder eg

disruption-py/drafts/machine/cmod/physics.py

Lines 128 to 133 in 7ecc92f

	import profiletools
	except Exception as e:
	logging.warning("Could not import profiletools or eqtools")
	logging.debug(traceback.format_exc())
	pass

idk if those are worth fixing?

Otherwise looks good!

[amdecker]

Yeah exactly -- we can remove the passes & leave the body empty of everything except the docstring because all the logic is implemented by subclasses.