Skip to content

Fix protected access#318

Merged
gtrevisan merged 5 commits intodevfrom
fix-protected-access
Sep 24, 2024
Merged

Fix protected access#318
gtrevisan merged 5 commits intodevfrom
fix-protected-access

Conversation

@gtrevisan
Copy link
Copy Markdown
Member

@gtrevisan gtrevisan commented Sep 23, 2024

fix:

close:

by:

  • removing leading underscore from _cached_results in core/physics_method/caching.py,
  • temporarily disabling the warning for two specific calls to _get_ip_parameters from settings/domain_setting.py.
  • flipping the convention of all physics methods in terms of the with/without underscore naming convention.

@gtrevisan gtrevisan requested a review from amdecker September 23, 2024 21:05
@gtrevisan gtrevisan added the linting Modifications about linting, formatting, and style label Sep 23, 2024
Copy link
Copy Markdown
Contributor

@amdecker amdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flipped the underscore/no underscore physics method

Comment thread disruption_py/machine/cmod/physics.py
@gtrevisan gtrevisan merged commit 2c2a7ba into dev Sep 24, 2024
@gtrevisan gtrevisan deleted the fix-protected-access branch September 24, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

linting Modifications about linting, formatting, and style

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants