Skip to content

Drop cache setting#423

Merged
gtrevisan merged 6 commits intodevfrom
drop-cache
Apr 2, 2025
Merged

Drop cache setting#423
gtrevisan merged 6 commits intodevfrom
drop-cache

Conversation

@gtrevisan
Copy link
Copy Markdown
Member

@gtrevisan gtrevisan commented Apr 1, 2025

  • drop all CacheSetting classes
  • drop cached_data and pre_filled_shot_data
  • slightly revamp the logic behind the REQUIRED_COLUMNS (= coords) dataframe
  • sort columns in final dataframe

@gtrevisan gtrevisan requested a review from zapatace April 1, 2025 18:12
@zapatace
Copy link
Copy Markdown
Contributor

zapatace commented Apr 2, 2025

I ran two tests (efit time base and np.arange(0.9, 1.0, 0.001)) with 212 shots and compared the four dataframes, two by two, from the dev and drop-cache branches. In all cases, the dataframes have identical numerical values, though the column order differs. Lacking the expertise to analyze the code in depth (for now), I am satisfied with this result and will approve the merge.

Copy link
Copy Markdown
Contributor

@zapatace zapatace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with results of testing.

@gtrevisan gtrevisan merged commit ea5972a into dev Apr 2, 2025
11 checks passed
@gtrevisan gtrevisan deleted the drop-cache branch April 2, 2025 18:14
@gtrevisan gtrevisan removed the request for review from yumouwei April 2, 2025 18:14
@gtrevisan gtrevisan mentioned this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants