Skip to content

Better exceptions#428

Merged
gtrevisan merged 8 commits intodevfrom
better-exceptions
Apr 3, 2025
Merged

Better exceptions#428
gtrevisan merged 8 commits intodevfrom
better-exceptions

Conversation

@gtrevisan
Copy link
Copy Markdown
Member

  • be resilient to any exception within the runner
  • further decorate some MDSplus exceptions
  • better logs for exceptions
  • avoid warnings if errors have already been raised (eg during setup)

@AlexSaperstein

This comment was marked as resolved.

@gtrevisan

This comment was marked as resolved.

@AlexSaperstein

This comment was marked as resolved.

@gtrevisan
Copy link
Copy Markdown
Member Author

the old simple example, which was the cli entry point, is now in the framework with a better name (disruption-py).
the defaults example never had defaults, only an empty shotlist.

anyways, I tried with this and it seems to be resilient (yet verbose) as desired:

poetry run disruption-py -l warning 1120215001 1120801004 1120801017 1120807019 1120816012 1120831018 1120914031 1120918013 1120920023 1120921002 1120921006 1120921030 1120921033 1150528006

@AlexSaperstein
Copy link
Copy Markdown
Contributor

gotcha. everything looks good when I'm running it

AlexSaperstein

This comment was marked as duplicate.

Copy link
Copy Markdown
Contributor

@yumouwei yumouwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new error log

@gtrevisan gtrevisan merged commit 60aebe6 into dev Apr 3, 2025
11 checks passed
@gtrevisan gtrevisan deleted the better-exceptions branch April 3, 2025 20:29
@gtrevisan gtrevisan mentioned this pull request Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants