Merged
Conversation
AlexSaperstein
approved these changes
Apr 3, 2025
Contributor
AlexSaperstein
left a comment
AlexSaperstein
left a comment
There was a problem hiding this comment.
I've never really used any of these. you're good to go on my end
yumouwei
approved these changes
Apr 4, 2025
Contributor
yumouwei
left a comment
yumouwei
left a comment
There was a problem hiding this comment.
I haven't seen these methods being used anywhere, so I'd say it's safe to remove them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keep your eyes peeled for this one!
are you able to take a look and see whether anything does deserve to survive?
I will run full tests to be safe -- full tests pass.