Conversation
Contributor
|
Here's a quick script I used to check if the bad shots affect the data fetched from the good shots. It passed for both CMOD & DIII-D. I'm having trouble testing on east EAST because VS Code release 1.99 stops supporting remote ssh into legacy linux distributions and I'm trying to sort that out. Update: it works on EAST as well |
yumouwei
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re-implement the good practice of closing the trees we opened after each shot.
if we catch an
MDSplusERROR, it might mean that we encountered a severely-corrupted MDSplus tree.in that case, the MDSplus connection itself might be compromised and would require a reconnection.
to mitigate this we purge any untrustworthy data related to our shot, but at least we will be able to retrieve healthy data for further shots processed by the same connection.
tested with both a 1-proc and 2-proc job with a bad shot, followed by a good shot: