Closed
Conversation
…ame=None as it's not needed
Contributor
Author
|
I just found out that |
gtrevisan
reviewed
Apr 10, 2025
Member
gtrevisan
left a comment
There was a problem hiding this comment.
the inout module is machine-agnostic, could we move this somewhere else in the DIII-D-specific module? maybe a helper function somewhere?
Contributor
Author
|
In terms of using PTDATA signal in SignalTimeSetting, for now this is addressed by the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows a user to use
conn.get_data('ip', tree_name='ptdata')to replace
conn.get_data(f'ptdata("ip", {params.shot_id}, tree_name='d3d')conn.get_data(f'ptdata("ip", {params.shot_id}, tree_name=None)For the moment, this is only needed for using
SignalTimeSettingwith PTDATA signals on DIII-D. Therefore I did not modify any expression ind3d/physics.pyor anywhere else. It also only works with simple expressions (i.e. it won't work with additional arithmetic operations).