Skip to content

Simplify log_settings#441

Merged
gtrevisan merged 1 commit intodevfrom
simplify-log-settings
Apr 16, 2025
Merged

Simplify log_settings#441
gtrevisan merged 1 commit intodevfrom
simplify-log-settings

Conversation

@gtrevisan
Copy link
Copy Markdown
Member

  • remove log_file_write_mode
  • remove log_to_console
  • remove use_custom_logging
  • rename file_log_level to file_level
  • rename console_log_level to console_level
  • rename log_file_path to file_path
  • add a from-dict equivalent to resolve_log_settings

@gtrevisan gtrevisan requested a review from yumouwei April 14, 2025 21:10
Copy link
Copy Markdown
Contributor

@yumouwei yumouwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works

@gtrevisan
Copy link
Copy Markdown
Member Author

thanks for testing! any thoughts about the renamed settings and the corresponding impact into your workflows?

@yumouwei
Copy link
Copy Markdown
Contributor

For my part, as long as I can print the logs on a terminal and save them to a file to check if anything went wrong then it's fine. I'm not really using it for anything more complicated than that.

@gtrevisan gtrevisan merged commit e414215 into dev Apr 16, 2025
12 checks passed
@gtrevisan gtrevisan deleted the simplify-log-settings branch April 16, 2025 12:38
@gtrevisan gtrevisan mentioned this pull request Apr 16, 2025
@gtrevisan gtrevisan changed the title simplify log_settings Simplify log_settings Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants