Remove previously added XFAILs due to east/east_1 tree issues#461
Merged
Remove previously added XFAILs due to east/east_1 tree issues#461
Conversation
…east_1 tree issue from 04/2025
yumouwei
force-pushed
the
east-remove-xpass
branch
from
5b2e787 to
1a2ad32
Compare
gtrevisan
force-pushed
the
east-remove-xpass
branch
from
aead416 to
403995b
Compare
gtrevisan
approved these changes
Jun 24, 2025
Member
gtrevisan
left a comment
gtrevisan
left a comment
There was a problem hiding this comment.
tests passed manually on cs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented changes
east/east_1tree errors. All these signals get their raw data from theeasttree.The remaining 2 signals (p_lhandp_rad) still show up as XFAIL instead of XPASS in the test. Both of them use data from theeast_1tree. I need to take a closer look to see what's causing the problem.p_lhandp_radfrom XFAILs as well as they now show up as XPASS.Related PRs