Open
Conversation
yumouwei
changed the title
gtrevisan
reviewed
Apr 9, 2026
Member
gtrevisan
left a comment
gtrevisan
left a comment
There was a problem hiding this comment.
what's the final effect of this change?
are you able to share a couple of plots for some shot?
also, have you tried executing full tests to see whether we need to mark anything as an expected failure?
| ------- | ||
| - original source: [get_Ip_parameters.m](https://github.com/MIT-PSFC/disruption-py/blob | ||
| /matlab/DIII-D/get_Ip_parameters.m) | ||
| - issues: #[506](https://github.com/MIT-PSFC/disruption-py/issues/506) |
Member
There was a problem hiding this comment.
you might want to add this PR, as well.
| t_epsoff += 0.001 | ||
| epsoff = interp1(t_epsoff, epsoff, params.times, "linear") | ||
| railed_indices = np.where(np.abs(epsoff) > 0.5) | ||
| if params.shot_id >= 198183: |
Member
There was a problem hiding this comment.
since we are using this in two places, let's choose a good name and make it a configuration parameter.
| - original source: [get_Ip_parameters_RT.m](https://github.com/MIT-PSFC/disruption-py | ||
| /blob/matlab/DIII-D/get_Ip_parameters_RT.m) | ||
| - pull requests: #[254](https://github.com/MIT-PSFC/disruption-py/pull/254) | ||
| - issues: #[506](https://github.com/MIT-PSFC/disruption-py/issues/506) |
Member
There was a problem hiding this comment.
you might want to add this PR, as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented changes in
get_ip_parametersandget_rt_ip_parametersas described in Issue 506