Draft
Conversation
* this adds a bottom-up checker that walks the circuit once, and checks - decomposability: no variable appears in more than one child of an AND - smoothness: every child of an OR mentions exactly the same variable scope Signed-off-by: IbrahimElk <ibrahim_elkaddouri@outlook.com>
Signed-off-by: IbrahimElk <ibrahim_elkaddouri@outlook.com>
Signed-off-by: IbrahimElk <ibrahim_elkaddouri@outlook.com>
Signed-off-by: IbrahimElk <ibrahim_elkaddouri@outlook.com>
* exported symbols (e.g. check_sdnnf) are visible for linking and debugging Signed-off-by: IbrahimElk <ibrahim_elkaddouri@outlook.com>
* this commit will be eventually reversed Signed-off-by: IbrahimElk <ibrahim_elkaddouri@outlook.com>
Signed-off-by: IbrahimElk <ibrahim_elkaddouri@outlook.com>
Signed-off-by: IbrahimElk <ibrahim_elkaddouri@outlook.com>
Signed-off-by: IbrahimElk <ibrahim_elkaddouri@outlook.com>
Contributor
Author
|
@jjcmoon do you think its best to merge now ? or rather later, when i complete the following issues in kompyle 5 15. I'll also clean up a bit the code in this PR, i have some commented out code that i should remove. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some property-checks for sd-DNNF circuits implemented using Klay.
Primarily, syntactic checks including decomposability and smoothness, and exposes the results to python.
This PR also adds tests covering these new check methods.