-
Notifications
You must be signed in to change notification settings - Fork 12
Remove interaction saver and simplify ProbeSaver #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
135 commits
Select commit
Hold shift + click to select a range
01c387e
Update Rails dependency to 8.0.2
Splines b02547d
Perform update via `bin/rails app:update` & manually review
Splines ebe0bc5
Fix load defaults version
Splines 5dfcdb6
Upgrade schema file
Splines 9665c60
Remove cache control header for test environment
Splines cb7d6a9
Fix RuboCop errors (mainly new `params.expect()` unsafe autocorrects)
Splines 128f0f9
Patch Devise for Rails 8
Splines 895e4bd
Fix incorrect array syntax in params
Splines 26c1a7d
Don't require an array for quizzes
Splines a7064ce
Remove array for question_attributes in vignettes
Splines b89605b
Use permit for structure_params & remove unused comment_params
Splines ffc0247
Expect lecture updates to fail (due to params being stricter)
Splines 96d80f0
Fix invalid syntax for course controller
Splines 0db5337
Merge branch 'next' into deps/rails-8
Splines 2eb35c5
Fix vignette @answers=nil error during preview
Splines 1a34ed2
Fix missing `basics.division` translation
Splines 4daa184
Permit `ValidationContext` class in `YAML.safe_load()`
Splines 47cfb6c
Remove duplicate config line
Splines 76f728c
Remove webpacker and sass-rails & add basic vite_rails config
Splines d8579d2
Move vite_client_tag to global _head file
Splines 95df0b5
Init basic bootstrap setup
Splines 410c124
Remove webpack-dev-server
Splines 2756918
Merge branch 'next' into deps/vite
Splines dde73cc
Use jquery with Vite (remove Ruby gem)
Splines c8567a5
Remove Sprockets (first migration step)
Splines 9ec1c8d
Delete webpacker configuration 🥳
Splines 4a0f633
Revert "Remove Sprockets (first migration step)"
Splines 8636b90
Remove empty API assets (legacy)
Splines 77206fb
Move stylesheets from `app/assets/stylesheets` to `app/frontend/entry…
Splines 57f0902
Remove jquery-ui (not to confuse with jQuery itself)
Splines c102fdf
Use Vite tag helpers
Splines 5ac088f
Remove old `app/javascript` folder (and move code to `application.js`)
Splines 41da60a
Fix Bootstrap SCSS imports
Splines 00f5a70
Add back in bootstrap_form gem
Splines d6bdcdf
Move stylesheets to subfolder
Splines f438fdc
Fix no default import of `friendly-challenge`
Splines de82e35
Update vite_stylesheet_tag subfolder & use explicit file endings
Splines 6d91ee4
Place javascript files in frontend folder
Splines 726ceea
Add back in rails-sass only for sprockets pipeline
Splines 9934458
Correct vite_javascript_tag paths for subfolder usage
Splines 4da0215
Use vite_image_tag instead of image_tag & correct paths
Splines 5579760
Convert sprocket requires to js imports
Splines 8792076
Use "~/" instead of "@/"
Splines 2e94bb6
Add coffeescript Vite plugin & fix js imports
Splines 260f587
Use image_tag for urls & add missing .scss file extension
Splines 10f7d6f
Include all bootstrap stylesheets
Splines 7f387eb
Fix CSS url path
Splines 3a09b21
Fix fonts path
Splines f5412ca
Remove console.log
Splines e0e9d28
Configure Vite in Docker Compose
Splines 891dba5
Load coffee plugin first to then inject JQuery
Splines 09c7738
Use turbolinks npm package instead of gem
Splines ee14c5a
Init fixing JS reference errors by using new ES6 import syntax
Splines e7ac3a7
Fix masonry & bootstrap/jquery issues
Splines e0d50b7
Rework einstein tiles p5 code for modern JS
Splines 81d421b
Bring back public assets to respective folder
Splines f354bad
Rework Thyme-related JS files
Splines 4b97edc
Globally define `initBootstrapPopovers`
Splines 1b16b72
Remove coffeescript Rails gem
Splines f82ab3e
Also initialize bootstrap popovers on page load
Splines 46359cc
Import bootstrap Toast for feedback JS
Splines f779bbe
Ignore SASS legacy API warnings
Splines 12f3722
Add back in missing p5 dependency
Splines 8361787
Setup js_routes for use with Vite
Splines ac1c946
Remove webpack-related npm packages
Splines d348c3c
Remove core-js dependency
Splines e3e5a5a
Remove regenerator-runtime
Splines aaf3dbc
Remove coffeescript dependency
Splines e20ba8a
Remove console.logs()
Splines 837c7db
Use production rails env for CI_CD asset bundling
Splines 1bd7536
Don't import Thyme-related components everywhere
Splines eedd106
Add back in coffee-rails
Splines 49f082e
Add in Rails UJS (before migration to Turbo)
Splines ba74207
Use window-scope for reloadUrl helper function
Splines acefcc4
Fix bootstrap stylesheet import in emails
Splines 1982a56
Add just command to simulate Vite production build
Splines e2a0b04
Remove accidentally commited mampf_routes
Splines da20b2f
Use Sprocket pipeline for Commontator & Thredded assets
Splines 2181b1f
Add back in devise-bootstrap-views
Splines acab846
Lint vite config & add back in Node globals to ESLint
Splines 9026bc4
Merge branch 'next' into deps/vite
Splines c044478
Remove sass-loader dependency
Splines aa5317f
Remove clicker sprocket syntax
Splines 7dece48
Fix geogebra assets inclusion
Splines 0e807fb
Fix missing Category import
Splines 4361f1c
Fix line too long
Splines 1a9d5b4
Fix talks.coffee -> talke.js & group according to JS/coffee
Splines 21a93d3
Configure vite for tests
Splines d6c97ea
Align test with dev Ruby environment
Splines 897d068
Remove premailer rails
Splines 6a47af5
Fix vite ruby host
Splines 2f4c267
Fix js-routes issues due to multiple recompiling
Splines b954c67
Merge branch 'next' into deps/vite
Splines 52d09b4
Only recompile js-routes once at container start
Splines d77d8ba
Fix lectures people select spec
Splines 0497b48
Use Turbolinks as Ruby Gem again
Splines 76a6e51
Fix setSelectedRange on undefined bug
Splines 7095828
Fix new lecture specs
Splines 85b3a3e
Fix annotations overview tests
Splines ada607b
Fix commontator JS calling
Splines 2aba38e
Don't manually set NODE_ENV in entrypoint script
Splines b892016
Add missing backslash to Dockerfile
Splines 2a32df1
Print node env
Splines 52c4dfe
Avoid test failure by not using ampersand HTML entity
Splines e960d97
Fix mixed JS/coffeescript (Erdbeere)
Splines 8965c33
Build assets in CI/CD using test env
Splines e81f456
Don't explicitly specify NODE_ENV
Splines 79314a9
Try to also set database url to empty string
Splines 1f5a6ca
Try to not init Rails app during asset precompilation
Splines d625f7a
Unify database adapter env variables
Splines bf9b4bd
Use new env variable in all places
Splines 95c8b13
Don't use vite_image_tag for email attachment urls
Splines 39bd7a3
Use autobuild for tests such that RSpec tests work
Splines 9e08eaf
Use Vite Dev Server also for local tests
Splines f343251
Don't use anonymous volume for public folder in tests
Splines 58b53a0
Remove webpacker env variable
Splines c988051
Fix rspec mampf container start (watch for exception)
Splines 44eed7c
Don't use any extra volume for public folder
Splines f405715
Try again to create an anonymous volume for `public/`
Splines 3eb57bf
Refactor interactions: remove export_interactions functionality and r…
fosterfarrell9 7d32e55
Remove interactions functionality and related code
fosterfarrell9 556126b
Remove study participant references from quizzes and related views
fosterfarrell9 0c28aae
Remove interactions table and related columns from probes and users
fosterfarrell9 33e2681
Remove commented-out remark_details method and related code from Quiz…
fosterfarrell9 6adb0d8
Rename session_id to attempt_token across models, views, and factories
fosterfarrell9 ac37cdc
Fix typo
fosterfarrell9 be99862
Merge branch 'next' into features/remove-interactions
Splines 61c8365
Remove PR-unrelated space
Splines d72ddb7
Rework migration timestamps
Splines c52c572
Apply change from next branch
Splines 72987f9
Remove unnecessary top-level comment
Splines aeeb0f9
Initialize attempt_token with a unique identifier in progress_counter…
fosterfarrell9 174be9c
Add index on attempt_token and correct columns in probes table
fosterfarrell9 d6b465e
Refactor probe success calculation to use a transaction and prevent r…
fosterfarrell9 2b37afb
Revert "Refactor probe success calculation to use a transaction and p…
fosterfarrell9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,15 @@ | ||
| class ProbeSaver | ||
| include Sidekiq::Worker | ||
|
|
||
| # rubocop:todo Metrics/ParameterLists | ||
| def perform(quiz_id, question_id, remark_id, correct, progress, session_id, | ||
| study_participant, input) | ||
| # rubocop:enable Metrics/ParameterLists | ||
| def perform(quiz_id, question_id, correct, progress, attempt_token) | ||
fosterfarrell9 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| probe = Probe.create(quiz_id: quiz_id, | ||
| question_id: question_id, | ||
| remark_id: remark_id, | ||
| correct: correct, | ||
| progress: progress, | ||
| session_id: session_id, | ||
| study_participant: study_participant, | ||
| input: input) | ||
| attempt_token: attempt_token) | ||
| return unless progress == -1 | ||
|
|
||
| success = Probe.where(session_id: session_id, correct: true).count | ||
| success = Probe.where(attempt_token: attempt_token, correct: true).count | ||
fosterfarrell9 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| probe.update(success: success) | ||
| end | ||
| end | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.