Skip to content

Fix GeoMakie tiles not being translated down and PlotConfig example issues#154

Merged
asinghvi17 merged 11 commits intomasterfrom
as/fix-geomakie
Nov 16, 2025
Merged

Fix GeoMakie tiles not being translated down and PlotConfig example issues#154
asinghvi17 merged 11 commits intomasterfrom
as/fix-geomakie

Conversation

@asinghvi17
Copy link
Copy Markdown
Member

@asinghvi17 asinghvi17 commented Nov 9, 2025

IIRC I initially didn't want to do this because it could potentially return different results based on projection.

But as long as your geoaxis is purely 2D, it will be fine. Any future GlobeAxis method would need a different thing anyway.

Fix #153
Fix #151

This translates tiles down by -10 by default, the same as happens in regular Axis.  I think this is probably OK for GeoAxis.  For GlobeAxis we'd need a separate plan.
Not that it was impeding any functionality but it was super annoying to look at
@asinghvi17 asinghvi17 changed the title Fix GeoMakie tiles not being translated down Fix GeoMakie tiles not being translated down and PlotConfig example issues Nov 9, 2025
@asinghvi17 asinghvi17 mentioned this pull request Nov 15, 2025
@lazarusA
Copy link
Copy Markdown
Collaborator

Maybe add the docstring if missing? We could always just warn in those cases in make.jl, but maybe is better to not ignore them 😬

@asinghvi17
Copy link
Copy Markdown
Member Author

Yeah I just didn't want to do that now, will try to do a follow-up PR with a full API

Added 'using Extents' to the plot configuration example.
@asinghvi17 asinghvi17 merged commit c6afac9 into master Nov 16, 2025
4 checks passed
@asinghvi17 asinghvi17 deleted the as/fix-geomakie branch November 16, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overlaid polygon covered up by tiles with GeoAxis Tyler.PlotConfig docs have broken example

2 participants