Merged
Conversation
Collaborator
|
Does mapping.csv need to be that big? |
Member
Author
Its really not optimal, but I haven't had time to find a better solution yet ;) I'm quite sure though if we put some time into it, there should be a better solution! |
asinghvi17
reviewed
Aug 3, 2024
| mini, maxi = extrema(bounds) | ||
| plot[1] = (mini[1], maxi[1]) | ||
| plot[2] = (mini[2], maxi[2]) | ||
| plot[3] = rotr90(data) |
Member
There was a problem hiding this comment.
Suggested change
| plot[3] = rotr90(data) | |
| # TODO: remove this once we can mutate image UVs in Makie | |
| plot[3] = rotr90(data) |
Comment on lines
+14
to
+15
| p = Point2f[(0, 0), (1, 0), (1, 1), (0, 1)] | ||
| GO.intersects(Polygon(p), Polygon(map(x -> x .- 1.1, p))) |
Member
There was a problem hiding this comment.
Suggested change
| p = Point2f[(0, 0), (1, 0), (1, 1), (0, 1)] | |
| GO.intersects(Polygon(p), Polygon(map(x -> x .- 1.1, p))) |
(orphaned code)
This was referenced Aug 3, 2024
Member
|
This looks super cool! |
Collaborator
|
The point cloud example also doesn't work. It never shows anything. |
Co-authored-by: Anshul Singhvi <anshulsinghvi@gmail.com>
asinghvi17
reviewed
Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors quite a lot of the package:
Tiling performance
Providers
Tile plotting
Tyler.Map, to change how the tiles look (allows to completely change plot type, or just to add some attribute like alpha, or pre/post process data/plot.Map3D
Map3Dto tyler, which callsMapwith parameters to create a 3d mapTODO