feat(service): add memory limit to batch size#132
Merged
vitalymelni merged 7 commits intoMapColonies:masterfrom Jan 1, 2024
Merged
feat(service): add memory limit to batch size#132vitalymelni merged 7 commits intoMapColonies:masterfrom
vitalymelni merged 7 commits intoMapColonies:masterfrom
Conversation
shimoncohen
requested review from
almog8k,
asafMasa and
shimoncohen
and removed request for
almog8k
shimoncohen
requested changes
Dec 21, 2023
vitalymelni
commented
Dec 21, 2023
shimoncohen
approved these changes
Dec 21, 2023
shimoncohen
changed the title
shimoncohen
approved these changes
Dec 24, 2023
…ze defined by bytes count
…adds new config in helm
vitalymelni
force-pushed
the
feature/use-batches-updating-tiles
branch
from
a5cf7cc to
1ff0f75
Compare
asafMasa
requested changes
Jan 1, 2024
asafMasa
requested changes
Jan 1, 2024
asafMasa
requested changes
Jan 1, 2024
asafMasa
reviewed
Jan 1, 2024
MergerService/src/run.cs
Outdated
|
|
||
| using (this._activitySource.StartActivity("saving tiles")) | ||
| { | ||
| this._logger.LogInformation($"[{methodName}] Update {tiles.Count} tiles"); |
Contributor
There was a problem hiding this comment.
replcae with this._logger.LogInformation($"[{methodName}] Updating tiles chunk Job: {task.JobId}, Task: {task.Id}"); and remove 2 redundent logs before the function
asafMasa
approved these changes
Jan 1, 2024
MergerService/src/run.cs
Outdated
| { | ||
| this._logger.LogInformation($"[{methodName}] Update {tiles.Count} tiles"); | ||
| target.UpdateTiles(tiles); | ||
| this._logger.LogDebug($"[{methodName}] UpdateRelativeProgress"); |
Contributor
There was a problem hiding this comment.
move this log inside "UpdateRelativeProgress" method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further information:
Adds a configuration to limit the amount of bytes of target tiles in the memory, writing the tiles in batches to the target