refactor: change service run structure and add test coverage#133
Merged
vitalymelni merged 35 commits intoMapColonies:masterfrom Jan 3, 2024
Merged
Conversation
shimoncohen
changed the title
asafMasa
requested changes
Dec 28, 2023
Contributor
asafMasa
left a comment
asafMasa
left a comment
There was a problem hiding this comment.
Great Job Please merge latest from master and fix remarks
shimoncohen
changed the title
shimoncohen
requested changes
Dec 28, 2023
vitalymelni
force-pushed
the
feature/add-merger-service-tests
branch
from
02216ca to
582121c
Compare
vitalymelni
force-pushed
the
feature/add-merger-service-tests
branch
from
dcee0c7 to
9fa9ad0
Compare
shimoncohen
requested changes
Jan 1, 2024
vitalymelni
force-pushed
the
feature/add-merger-service-tests
branch
from
8d6ffeb to
6de35b0
Compare
vitalymelni
force-pushed
the
feature/add-merger-service-tests
branch
from
c8976f3 to
89800d2
Compare
shimoncohen
approved these changes
Jan 2, 2024
asafMasa
requested changes
Jan 3, 2024
| File.ReadAllBytes("4_upscaled_3_13.jpeg"), | ||
| }; | ||
|
|
||
| yield return new object[] { |
Contributor
There was a problem hiding this comment.
please update upscale test for varius Png's:
8-bit
24-bit
32-bit
64-bit
Background: The scenario is that we recieve 8-bit and use image magic to declare it as png-32 and then set it to target
When we read it from target we don't check or set it to 32 Bit in imageMagic in that case i don't know what format it thinks it is but it's beeing sent to upscale when needed - this may cause an exception that i want to check in tests
asafMasa
requested changes
Jan 3, 2024
asafMasa
approved these changes
Jan 3, 2024
…nsparent-tiles fix: upscale not working on tiles with partial transparancy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further information:
Add new unit tests for the merger service project, and adds some tests of the image processing classes