Skip to content

Support ConstructUsing in CollectionAdapter #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrerav merged 1 commit into from
Jun 27, 2022
Merged

Support ConstructUsing in CollectionAdapter #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/Mapster.Tests/WhenMappingCollections.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,19 @@ public void TestEnumList()
}
}

[TestMethod]
public void RespectConstructUsing()
{
var source = new List<int> { 1, 1, 3, };

var result = source
.BuildAdapter()
.ForkConfig(x => x.ForDestinationType<ICollection<string>>().ConstructUsing(() => new HashSet<string>()))
.AdaptToType<ICollection<string>>();

result.ShouldBe(new List<string> { "1", "3", });
}

#region TestClass

[Flags]
Expand Down
7 changes: 7 additions & 0 deletions src/Mapster/Adapters/CollectionAdapter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,13 @@ protected override bool CanInline(Expression source, Expression? destination, Co

protected override Expression CreateInstantiationExpression(Expression source, Expression? destination, CompileArgument arg)
{
//if there is constructUsing, use constructUsing
var constructUsing = arg.GetConstructUsing();
if (constructUsing != null)
{
return base.CreateInstantiationExpression(source, destination, arg);
}

var listType = arg.DestinationType;
if (arg.DestinationType.GetTypeInfo().IsInterface)
{
Expand Down