MDEV-38631 Remove unused FTS debug directives and dead code #4583
+3
−553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Thirunarayanan
force-pushed
the
MDEV-38631
branch
from
a4b1180 to
cf84004
Compare
dr-m
reviewed
Jan 23, 2026
Contributor
dr-m
left a comment
dr-m
left a comment
There was a problem hiding this comment.
Can we also remove the following, which are never defined?
#ifdef FTS_DEBUG
#ifdef FTS_CACHE_SIZE_DEBUG
#ifdef FTS_MULT_INDEX
dr-m
reviewed
Jan 23, 2026
Contributor
dr-m
left a comment
dr-m
left a comment
There was a problem hiding this comment.
There is also unreachable code inside #ifdef MYSQL_STORE_FTS_DOC_ID. What is its purpose? Is it something that was implemented in MySQL but not MariaDB?
Remove several unused debugging preprocessor directives from the FTS module that were never effectively used for debugging purposes and represent dead code. Removed debug directives: - DEBUG_FTS_SORT_PRINT: FTS sorting debug output macros - FTS_INTERNAL_DIAG_PRINT: Internal FTS diagnostic printing - FTS_OPTIMIZE_DEBUG: FTS optimization debugging functions - MYSQL_STORE_FTS_DOC_ID: Store fts doc id in FTS_DOC_ID field - FTS_DEBUG: Debug for fulltext index - FTS_CACHE_SIZE_DEBUG: Assign max and min fulltext cache size - FTS_MULT_INDEX: Updated fulltext index - Removed FTS_OPTIMIZE_START_TIME and FTS_OPTIMIZE_END_TIME constants These debug directives were never properly integrated into the build system and provided no value for production debugging and also improves code clarity for the FTS module.
Thirunarayanan
force-pushed
the
MDEV-38631
branch
from
cf84004 to
e770e62
Compare
dr-m
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove several unused debugging preprocessor directives from the FTS module that were never effectively used for debugging purposes and represent dead code.
Removed debug directives:
DEBUG_FTS_SORT_PRINT: FTS sorting debug output macros
FTS_INTERNAL_DIAG_PRINT: Internal FTS diagnostic printing
FTS_OPTIMIZE_DEBUG: FTS optimization debugging functions
MYSQL_STORE_FTS_DOC_ID: Store fts doc id in FTS_DOC_ID field
FTS_DEBUG: Debug for fulltext index
FTS_CACHE_SIZE_DEBUG: Assign max and min fulltext cache size
FTS_MULT_INDEX: Updated fulltext index
Removed FTS_OPTIMIZE_START_TIME and FTS_OPTIMIZE_END_TIME constants
These debug directives were never properly integrated into the build system and provided no value for production debugging and also improves code clarity for the FTS module.