Add standard includes for ASM#117
Merged
MarkSchofield merged 1 commit intoMarkSchofield:mainfrom Oct 29, 2024
Merged
Conversation
paulfd
force-pushed
the
paulfd/add-asm-includes
branch
from
a963315 to
de96d95
Compare
Owner
|
Thanks for the contribution. This should fix #115, right? There's a few ASM variants, I'm fine starting the ARM_MASM - any idea if others would need the Windows SDK .inc files? |
MarkSchofield
approved these changes
Oct 29, 2024
Contributor
Author
|
Yeah indeed I didn't even check the issues, sorry! I do not know about other variants, just got bit by it as in #115 and had to add it to the loop. I guess it'd make sense to add all the Windows-supported ones, although it can also be on a need basis. |
This was referenced Nov 2, 2024
InCom-0
pushed a commit
to InCom-0/cmake_WindowsToolchain
that referenced
this pull request
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some ASM include files at least in
"${WINDOWS_KITS_INCLUDE_PATH}/shared".