Fixes to 'Windows.EWDK.toolchain.cmake'#137
Merged
MarkSchofield merged 1 commit intomainfrom Nov 17, 2025
Merged
Conversation
403ca2c to
c208621
Compare
c208621 to
cee36e3
Compare
InCom-0
pushed a commit
to InCom-0/cmake_WindowsToolchain
that referenced
this pull request
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136.
As
Windows.MSVC.toolchain.cmakehas been cleaned-up and improved over time it canonicalized supportedCMAKE_SYSTEM_PROCESSORvalues and - inadvertently brokeWindows.EWDK.toolchain.cmake. Since GitHub runners don't have the EWDK installed, and don't have enough free space to install the EWDK, then it's tricky to catch such regressions. This change fixes things, making a few changes:CMAKE_SYSTEM_PROCESSORto$ENV{VSCMD_ARG_TGT_ARCH}, I'm checking$ENV{VSCMD_ARG_TGT_ARCH}and settingCMAKE_SYSTEM_PROCESSORto the correct value.$ENV{VSCMD_ARG_TGT_ARCH}corresponds to a matchingCMAKE_HOST_SYSTEM_PROCESSOR, thenCMAKE_SYSTEM_PROCESSORisn't set to avoid 'cross-compiling'.I validated with the "EWDK_ge_release_svc_prod1_26100_250904-1728.iso" EWDK. I mounted the ISO to E: and ran: