Replace include_directories by CMAKE_${LANG}_STANDARD_INCLUDE_DIRECTORIES#69
Merged
MarkSchofield merged 1 commit intomainfrom Jun 10, 2023
Merged
Replace include_directories by CMAKE_${LANG}_STANDARD_INCLUDE_DIRECTORIES#69MarkSchofield merged 1 commit intomainfrom
MarkSchofield merged 1 commit intomainfrom
Conversation
InCom-0
pushed a commit
to InCom-0/cmake_WindowsToolchain
that referenced
this pull request
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @bebuch for calling out (in #67) that the Toolchain should be setting
CMAKE_CXX_STANDARD_INCLUDE_DIRECTORIES, and not callinginclude_directories. This change removes allinclude_directoriescalls and instead buildsCMAKE_${LANG}_STANDARD_INCLUDE_DIRECTORIESforLANGvalues ofC,CXX,RC.