Fix regex to get MSVC version#75
Merged
MarkSchofield merged 1 commit intoMarkSchofield:mainfrom Sep 5, 2023
Merged
Conversation
Owner
|
Thanks for the fix! |
InCom-0
pushed a commit
to InCom-0/cmake_WindowsToolchain
that referenced
this pull request
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MSVC version number is not being properly parsed through the
cl.exe -Bvcommand on my machine. The issue seems to be with the greedy regex pattern.*which matches the rest of the line eating up the version number. Changing this pattern to[^0-9]*seems to work fine.