Windows.MSVC.toolchain.cmake shouldn't fallback to non-Spectre folders on Spectre builds#95
Merged
MarkSchofield merged 4 commits intomainfrom Feb 20, 2024
Merged
Conversation
…s on Spectre builds
MarkSchofield
force-pushed
the
mschofie/library-fallback
branch
from
f5556b1 to
469062f
Compare
InCom-0
pushed a commit
to InCom-0/cmake_WindowsToolchain
that referenced
this pull request
Mar 10, 2026
…s on Spectre builds (MarkSchofield#95)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion #93 talks about the options of opt-ing-in-to and falling-back-from Spectre libraries. This PR changes behavior to not include the non-Spectre paths if Spectre libraries have been asked for.