Have cpp files depend on same named include files.#2
Open
KOGrover wants to merge 1 commit intoMarkoPaul0:masterfrom
Open
Have cpp files depend on same named include files.#2KOGrover wants to merge 1 commit intoMarkoPaul0:masterfrom
KOGrover wants to merge 1 commit intoMarkoPaul0:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the code was not re-built if just an include file changed.
The build logic could likely be improved. E.g. use target dependent variables and have a 'debug' target. It would be more intuitive than setting BUILD_MODE to 'dbg'. It would also also you to build release and debug code in one make invocation.
....
CXXFLAGS = -g3 -gdwarf2
CCFLAGS = -g3 -gdwarf2
all: executable
debug: CXXFLAGS += -DDEBUG -g
debug: CCFLAGS += -DDEBUG -g
debug: executable
....
I can work on that if you have an interest.
I'm not really a C++ programmer, so I would need to research what current best practices are.