Fix: exec approvals linter errors#34
Merged
MarlBurroW merged 1 commit intoMarlBurroW:mainfrom Mar 25, 2026
Merged
Conversation
MarlBurroW
approved these changes
Mar 25, 2026
Owner
MarlBurroW
left a comment
MarlBurroW
left a comment
There was a problem hiding this comment.
Clean fix for the React strict-mode / exhaustive-deps linter warnings. Good use of useMemo to derive the filtered approvals list instead of calling setState directly in the effect body, and the deferred tick pattern in the modal avoids the synchronous state update issue nicely. Tests updated accordingly. LGTM 👍
Contributor
Author
|
All done - should be good for review and merge. |
Owner
|
Looks great, CI is green — merged! Thanks Wolfgang 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes lint violations. Sorry, I missed re-running that on my last push for #33.
Type of change
Checklist
npm run lintpasses with 0 errorsnpm run buildsucceedsnpm testpasses.envvalues committedScreenshots
N/A — no visual changes