Skip to content

Feat: Load agents from gateway#35

Merged
MarlBurroW merged 1 commit intoMarlBurroW:mainfrom
wnagele:agents_list
Mar 25, 2026
Merged

Feat: Load agents from gateway#35
MarlBurroW merged 1 commit intoMarlBurroW:mainfrom
wnagele:agents_list

Conversation

@wnagele
Copy link
Copy Markdown
Contributor

@wnagele wnagele commented Mar 25, 2026

Description

Fetch available agents from the gateway via agents.list instead of deriving the agent picker from existing sessions. Previously, the "New" session dropdown only showed agents that already had sessions — meaning users couldn't start a session with an agent they hadn't used before. Now the agent list is fetched server-side on connect, and the dropdown still only appears when 2+ agents are available.

Type of change

  • 🐛 Bug fix
  • ✨ New feature
  • ♻️ Refactor (no behavior change)
  • 📝 Documentation
  • 🎨 Style / UI
  • ⚡ Performance
  • 🧪 Tests
  • 🔧 CI / tooling

Checklist

  • npm run lint passes with 0 errors
  • npm run build succeeds
  • npm test passes
  • Tested in Dark, Light, and OLED themes
  • Mobile-responsive (375px+)
  • i18n keys added for new user-facing strings (EN + FR)
  • No secrets or .env values committed
  • Commit messages follow Conventional Commits

Screenshots (if UI change)

n/a no visual changes

@wnagele wnagele marked this pull request as draft March 25, 2026 19:37
Copy link
Copy Markdown
Owner

@MarlBurroW MarlBurroW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean refactor! Loading agents from the gateway instead of deriving them from session keys is the right approach — more reliable and decoupled.

A few notes:

  • Tests 👍 Nice to see the new NewSessionSplitButton test file covering the key scenarios (empty, single, multi-agent, interactions).
  • The agents.list call fails gracefully with a console warning, which is good for backward compatibility with older gateways.
  • Minor: NewSessionSplitButton is now exported — intentional for testing, but worth noting it's part of the public API now.
  • The PR template checklist is unfilled — would be good to tick the relevant boxes for completeness.

LGTM, merging once CI is green.

@wnagele wnagele marked this pull request as ready for review March 25, 2026 19:44
@wnagele
Copy link
Copy Markdown
Contributor Author

wnagele commented Mar 25, 2026

Feedback addressed - ready for review and merge.

@MarlBurroW MarlBurroW merged commit 70a7b20 into MarlBurroW:main Mar 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants