Save flash - use DEBUG for SERIAL (UBL)#28184
Save flash - use DEBUG for SERIAL (UBL)#28184classicrocker883 wants to merge 19 commits intoMarlinFirmware:bugfix-2.1.xfrom
Conversation
|
Many advanced users do not use displays, they are far to limiting. Now if you where to add a feature to advanced eg "DISABLE_UBL_SERIAL_CHITCHAT" or something like that I think this would be a better option than redefining it all as debugging. the user gets to choose if they want it or not. |
|
so far reverted the DEBUG from SERIAL to have one thing I found is |
|
all seems well, just not sure if |
… into bugfix-2.1.x-November3
Used AVR_ATmega2560_FAMILY - maybe instead of AVR_ATmega2560? // O2 gives smaller code than Os on A2560
Description
ChangingSERIAL_ECHO*toDEBUG_ECHO*Add option to disable serial output for UBL in ubl_G29.cpp results in saving ~1976 bytes (previously 1432) using new
DISABLE_UBL_SERIAL_CHITCHATDEBUG_ECHO_SPto debug_out.hweight_factortostatic void smart_fill_wlsf(const float )andTERN(AVR_ATmega2560_FAMILY, __O2, __Os); // O2 gives smaller code than Os on A2560Probably some serial echo could be kept, after allDEBUG_LEVELING_FEATUREis "detailed logging of G28, G29, M48, etc.".Tip
Thoughts?
Comments?
Suggestions?
Changes?
Requirements
Benefits
DEBUG_LEVELING_FEATURE/VALIDATE_MESH_TILTConfigurations
Related Issues
there are multiple errors when
VALIDATE_MESH_TILTis enabled (in ubl_g29.cpp) - such asgotzandprobe_ptare undefined.this PR does fix that by rearranging the values