Skip to content

Improve on Z_AFTER_PROBING#28231

Open
classicrocker883 wants to merge 19 commits intoMarlinFirmware:bugfix-2.1.xfrom
classicrocker883:bugfix-2.1.x-December4
Open

Improve on Z_AFTER_PROBING#28231
classicrocker883 wants to merge 19 commits intoMarlinFirmware:bugfix-2.1.xfrom
classicrocker883:bugfix-2.1.x-December4

Conversation

@classicrocker883
Copy link
Contributor

@classicrocker883 classicrocker883 commented Dec 17, 2025

Description

For now, this replaces Z_AFTER_PROBING from essentially an int to a bool,
uses Z_POST_CLEARANCE as value instead

  • Add Voxelab Aquila (GD32F103RC) to tests (could be moved to another PR)
    • change platform / platform_packages which use less flash

Requirements

Benefits

Configurations

Moved Z_POST_CLEARNACE to Conditionals-3-etc.h
Added Z_AFTER_PROBING also so that it is enabled automatically when UBL is enabled automatically - under other conditions

Related Issues

  • NONE() doesn't seem to be the pure opposite of ALL() and acts more like !ANY()

before, in motion.cpp, probe.move_z_after_probing() in void do_move_after_z_homing() couldn't be used since Z_POST_CLEARANCE was always defined before. so it was moved ahead.

(original)

  void do_move_after_z_homing() {
    DEBUG_SECTION(mzah, "do_move_after_z_homing", DEBUGGING(LEVELING));
    #ifdef Z_POST_CLEARANCE
      do_z_clearance(
        Z_POST_CLEARANCE,
        ALL(HOMING_Z_WITH_PROBE, HAS_STOWABLE_PROBE) && TERN0(HAS_BED_PROBE, endstops.z_probe_enabled),
        true
      );
    #elif ENABLED(USE_PROBE_FOR_Z_HOMING)
      probe.move_z_after_probing();
    #endif
  }

@classicrocker883
Copy link
Contributor Author

These may or may not need to be enabled no matter what (as they were before):

[gcode/probe/G30.cpp‎]
[gcode/bedlevel/abl/G29.cpp]
[feature/bedlevel/ubl/ubl_G29.cpp‎]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant