Improve on Z_AFTER_PROBING#28231
Open
classicrocker883 wants to merge 19 commits intoMarlinFirmware:bugfix-2.1.xfrom
Open
Improve on Z_AFTER_PROBING#28231classicrocker883 wants to merge 19 commits intoMarlinFirmware:bugfix-2.1.xfrom
Z_AFTER_PROBING#28231classicrocker883 wants to merge 19 commits intoMarlinFirmware:bugfix-2.1.xfrom
Conversation
Contributor
Author
These may or may not need to be enabled no matter what (as they were before):[gcode/probe/G30.cpp] |
add DISABLE_Z_POST_CLEARANCE for DWIN_LCD_PROUI
… into bugfix-2.1.x-December4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For now, this replaces
Z_AFTER_PROBINGfrom essentially anintto abool,uses
Z_POST_CLEARANCEas value insteadplatform/platform_packageswhich use less flashRequirements
Benefits
Configurations
Moved
Z_POST_CLEARNACEto Conditionals-3-etc.hAdded
Z_AFTER_PROBINGalso so that it is enabled automatically when UBL is enabled automatically - under other conditionsRelated Issues
NONE()doesn't seem to be the pure opposite ofALL()and acts more like!ANY()before, in motion.cpp,
probe.move_z_after_probing()invoid do_move_after_z_homing()couldn't be used sinceZ_POST_CLEARANCEwas always defined before. so it was moved ahead.(original)