Don't trigger babystepping on double click if encoder moved#28312
Open
dbuezas wants to merge 1 commit intoMarlinFirmware:bugfix-2.1.xfrom
Open
Don't trigger babystepping on double click if encoder moved#28312dbuezas wants to merge 1 commit intoMarlinFirmware:bugfix-2.1.xfrom
dbuezas wants to merge 1 commit intoMarlinFirmware:bugfix-2.1.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I moved my preheat menu items to the main menu so I can preheat quickly and selecting it triggers Z baby stepping. This is because clicking it also makes the menu go back to the status screen.
This MR adds a simple check for the encoder position so double click doesn't trigger when one does click-move-click.
Sounds too specific for myself, but it removes the problem for any other main menu item that sends the lcd back to the status screen, so IMO it isn't
Requirements
Benefits
Configurations
Related Issues