Skip to content

Add get_bsky_post_by_url example#424

Merged
MarshalX merged 5 commits into
MarshalX:mainfrom
DGaffney:patch-1
Nov 14, 2024
Merged

Add get_bsky_post_by_url example#424
MarshalX merged 5 commits into
MarshalX:mainfrom
DGaffney:patch-1

Conversation

@DGaffney
Copy link
Copy Markdown
Contributor

@DGaffney DGaffney commented Nov 8, 2024

Didn't have an example of this, needed one, so here ya go!

@MarshalX
Copy link
Copy Markdown
Owner

MarshalX commented Nov 8, 2024

Hi! Thank you for your contribution. Pls check why linter fails. And let's rename file like get bsky posts by url. Since this url format is full about frontend implementation

@DGaffney
Copy link
Copy Markdown
Contributor Author

DGaffney commented Nov 8, 2024

Hi! Thank you for your contribution. Pls check why linter fails. And let's rename file like get bsky posts by url. Since this url format is full about frontend implementation

sounds good! I'll rename after this linter run

@DGaffney
Copy link
Copy Markdown
Contributor Author

DGaffney commented Nov 8, 2024

@MarshalX can you resolve this one? Not sure what its complaining about at this point

@MarshalX MarshalX changed the title Create get_posts_by_url.py Add get_bsky_post_by_url example Nov 12, 2024
@MarshalX
Copy link
Copy Markdown
Owner

@DGaffney done. verify pls

@MarshalX MarshalX merged commit ab74814 into MarshalX:main Nov 14, 2024
@DGaffney
Copy link
Copy Markdown
Contributor Author

@DGaffney done. verify pls

Sorry I missed this - thank you for the merge! Curious to know, have you put anything together for jetstream in the repo yet? Quick search for the keyword yields nothing. If you have a sense of how you'd like to get it in I'd be happy to slap something together

@MarshalX
Copy link
Copy Markdown
Owner

MarshalX commented Nov 14, 2024

@DGaffney I did not yet, but should be just a little work. Wanna to have it in SDK someday because traffic is huge

I want to reuse base websocket clients. Which will not parse atproto frames, by just json. And speaking of the Jetstream models it uses own ones as I know. So just describe it with pydantic. I hope it will reuse post models that we have already

@DGaffney
Copy link
Copy Markdown
Contributor Author

@DGaffney I did not yet, but should be just a little work. Wanna to someday because traffic is huge

I want to reuse base websocket clients. Which will not parse frames, by just json. And speaking of the Jetstream models it uses own ones as I know. So just describe it with pydantic

Ok! When I can set aside some time the next few day's I'll get it in - Jaz is trying to push people over to jetstream so getting it in will help reduce load

@MarshalX
Copy link
Copy Markdown
Owner

MarshalX commented Nov 14, 2024

@DGaffney Awesome! Thank you! A few notes to keep in mind:

  • both async and sync clients must be provided
  • use pydantic`s json serializer for speed
  • the public interface should be as much as simple and looks like the old one for real firehose (i want to have as smooth migration for ppl as possible)
  • simple random rolling between 4 official jetstreams instances by default

@DGaffney
Copy link
Copy Markdown
Contributor Author

@DGaffney Awesome! Thank you! A few notes to keep in mind:

  • both async and sync clients must be provided
  • use pydantic`s json serializer for speed
  • the public interface should be as much as simple and looks like the old one for real firehose (i want to have as smooth migration for ppl as possible)
  • simple random rolling between 4 official jetstreams instances by default

Sounds good! I'll at least get the ball rolling for you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants