Add Python 3.14 support#629
Merged
Merged
Conversation
Closed
zzstoatzz
added a commit
to zzstoatzz/atproto
that referenced
this pull request
Oct 22, 2025
Pydantic 2.12.3+ warns that Field(default=None) has no effect in discriminated union contexts, as optionality is already handled by the Optional[] wrapper. This fix removes the default=None parameter from Field() for both: - Discriminated unions (with discriminator='py_type') - Unknown unions (without discriminator) The previous fix in PR MarshalX#627 addressed optional fields with constraints, but didn't cover discriminated unions which have their own Field() generation logic in _get_ref_union_typehint(). Fixes issue MarshalX#625 (additional cases found in PR MarshalX#629)
zzstoatzz
added a commit
to zzstoatzz/atproto
that referenced
this pull request
Oct 22, 2025
Pydantic 2.12.3+ warns that Field(default=None) has no effect in discriminated union contexts, as optionality is already handled by the Optional[] wrapper. This fix removes the default=None parameter from Field() for both: - Discriminated unions (with discriminator='py_type') - Unknown unions (without discriminator) The previous fix in PR MarshalX#627 addressed optional fields with constraints, but didn't cover discriminated unions which have their own Field() generation logic in _get_ref_union_typehint(). Fixes issue MarshalX#625 (additional cases found in PR MarshalX#629)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.