Skip to content

Update lexicons fetched from 39b5c08 committed 2025-11-05T17:11:32Z#631

Merged
MarshalX merged 1 commit into
mainfrom
update-lexicons
Nov 8, 2025
Merged

Update lexicons fetched from 39b5c08 committed 2025-11-05T17:11:32Z#631
MarshalX merged 1 commit into
mainfrom
update-lexicons

Conversation

@MarshalX
Copy link
Copy Markdown
Owner

This PR was automatically generated

@MarshalX MarshalX self-assigned this Oct 31, 2025
@MarshalX MarshalX changed the title Update lexicons fetched from 15fe80c committed 2025-10-29T22:16:06Z Update lexicons fetched from 39b5c08 committed 2025-11-05T17:11:32Z Nov 7, 2025
@MarshalX
Copy link
Copy Markdown
Owner Author

MarshalX commented Nov 8, 2025

there is an edge case. ref resolved for Main class instead of Record. requires a fix to pass

@MarshalX
Copy link
Copy Markdown
Owner Author

MarshalX commented Nov 8, 2025

in TS sdk they do a trick with double import with both names:

as Main:

export interface Main {
  $type: 'com.atproto.lexicon.schema'
  /** Indicates the 'version' of the Lexicon language. Must be '1' for the current atproto/Lexicon schema system. */
  lexicon: number
  [k: string]: unknown
}

as Record:

export {
  type Main as Record,
  isMain as isRecord,
  validateMain as validateRecord,
}

should we just create put Main = Record at the end of the file? i do not see clean solution for the ref resolving to handle it. the scheme itself points to #main which is right

@MarshalX
Copy link
Copy Markdown
Owner Author

MarshalX commented Nov 8, 2025

fixed by adding lookup in builder.build_record_models() and hard rename from Main to Record if found

@MarshalX MarshalX merged commit c8a2492 into main Nov 8, 2025
25 of 26 checks passed
@MarshalX MarshalX deleted the update-lexicons branch November 8, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant