_⚠️ Potential issue_

[MasumRab]

⚠️ Potential issue

Exception tuple references nltk when it may be undefined

If import nltk fails, the name nltk doesn’t exist, so evaluating nltk.downloader.ErrorMessage in the same except tuple raises a secondary NameError, masking the real problem.

-try:
-    import nltk
-    nltk.data.find('taggers/averaged_perceptron_tagger')
-    nltk.data.find('tokenizers/punkt')
-    HAS_NLTK = True
-except (ImportError, nltk.downloader.ErrorMessage):
-    HAS_NLTK = False
+try:
+    import nltk
+    nltk.data.find('taggers/averaged_perceptron_tagger')
+    nltk.data.find('tokenizers/punkt')
+except Exception:          # covers ImportError and lookup errors
+    HAS_NLTK = False
+else:
+    HAS_NLTK = True

This guards against the undefined-name pitfall while still keeping the logic simple.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

try:
    import nltk
    # Check if necessary NLTK data is available (downloads should be handled by launch.py)
    nltk.data.find('taggers/averaged_perceptron_tagger')
    nltk.data.find('tokenizers/punkt')
except Exception:          # covers ImportError and lookup errors
    HAS_NLTK = False
else:
    HAS_NLTK = True

🤖 Prompt for AI Agents

In server/python_nlp/action_item_extractor.py around lines 8 to 13, the except
clause references nltk.downloader.ErrorMessage which can cause a NameError if
the import nltk fails. To fix this, separate the exception handling into two
except blocks: one catching ImportError alone, and another catching
nltk.downloader.ErrorMessage only if nltk was successfully imported. This avoids
referencing nltk when it may be undefined.

Originally posted by @coderabbitai[bot] in #48 (comment)

[linear]

MAS-30 _⚠️ Potential issue_