Skip to content

Enabled strong name for WPF projects#1890

Merged
Keboo merged 2 commits intoMaterialDesignInXAML:masterfrom
shjin404:master
Jun 12, 2020
Merged

Enabled strong name for WPF projects#1890
Keboo merged 2 commits intoMaterialDesignInXAML:masterfrom
shjin404:master

Conversation

@shjin404
Copy link
Copy Markdown
Contributor

@shjin404 shjin404 commented Jun 4, 2020

MaterialDesignInXamlToolKit is missing strong-name. Some organizations require their assemblies to be strong-named due to various reasons including historical reasons, and it causes a blocking issue in some cases especially when build time conversion of NuGet assemblies to strong name is not acceptable.

Given Microsoft's new recommendation for open source project, I am including the private key as-is to the repository as strong name is no longer recognized as security mechanism but purely a unique identity mechanism.

See https://docs.microsoft.com/en-us/dotnet/standard/assembly/strong-named

Given people are consuming this by NuGet package, this change should not cause issues as building their project again with NuGet with strong named assemblies would generate correct new reference metadata.

@Keboo Keboo self-requested a review June 8, 2020 05:25
@Keboo Keboo added this to the 3.2.0 milestone Jun 8, 2020
@Keboo Keboo added the release notes Items are likely to be highlighted in the release notes. label Jun 12, 2020
@Keboo Keboo merged commit 5096501 into MaterialDesignInXAML:master Jun 12, 2020
@greuelpirat
Copy link
Copy Markdown
Contributor

I can not start MaterialDesignDemo any more:

System.IO.FileLoadException: Die Datei oder Assembly "ShowMeTheXAML, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null" oder eine Abhängigkeit davon wurde nicht gefunden. Eine Assembly mit starkem Namen ist erforderlich. (Ausnahme von HRESULT: 0x80131044)
Dateiname: "ShowMeTheXAML, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null"
   bei MaterialDesignColors.WpfExample.App.OnStartup(StartupEventArgs e)
...

I think this is because of the strong name changes. Any else have this problem?

@Keboo
Copy link
Copy Markdown
Member

Keboo commented Jun 14, 2020

@greuelpirat yea that was my fault. Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement release notes Items are likely to be highlighted in the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants