Enabled strong name for WPF projects#1890
Merged
Keboo merged 2 commits intoMaterialDesignInXAML:masterfrom Jun 12, 2020
shjin404:master
Merged
Enabled strong name for WPF projects#1890Keboo merged 2 commits intoMaterialDesignInXAML:masterfrom shjin404:master
Keboo merged 2 commits intoMaterialDesignInXAML:masterfrom
shjin404:master
Conversation
Contributor
|
I can not start MaterialDesignDemo any more: I think this is because of the strong name changes. Any else have this problem? |
Member
|
@greuelpirat yea that was my fault. Should be fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaterialDesignInXamlToolKit is missing strong-name. Some organizations require their assemblies to be strong-named due to various reasons including historical reasons, and it causes a blocking issue in some cases especially when build time conversion of NuGet assemblies to strong name is not acceptable.
Given Microsoft's new recommendation for open source project, I am including the private key as-is to the repository as strong name is no longer recognized as security mechanism but purely a unique identity mechanism.
See https://docs.microsoft.com/en-us/dotnet/standard/assembly/strong-named
Given people are consuming this by NuGet package, this change should not cause issues as building their project again with NuGet with strong named assemblies would generate correct new reference metadata.