Added null check to DialogHost.ShowInternal#1977
Merged
Keboo merged 1 commit intoMaterialDesignInXAML:masterfrom Jul 13, 2020
Jesus805:master
Merged
Added null check to DialogHost.ShowInternal#1977Keboo merged 1 commit intoMaterialDesignInXAML:masterfrom Jesus805:master
Keboo merged 1 commit intoMaterialDesignInXAML:masterfrom
Jesus805:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are scenarios when you would like to Show the DialogHost but not change it's content. I came across this problem when working with Prism Library. I wanted to asynchronously show a Dialog but keep the existing Dialoghost.DialogContent control (which I defined as a Prism region). By setting content to null in Window.ShowDialog(), the content will not be changed.
I am open to discussion if there is a better way of implementing this and I'm happy to provide a sample project if it helps clarify this use case.