Skip to content

Expand Demo to Include Secondary Variants for Buttons + New 'Paper' Button#2376

Merged
Keboo merged 13 commits intoMaterialDesignInXAML:masterfrom
rrs:master
Jul 17, 2021
Merged

Expand Demo to Include Secondary Variants for Buttons + New 'Paper' Button#2376
Keboo merged 13 commits intoMaterialDesignInXAML:masterfrom
rrs:master

Conversation

@rrs
Copy link
Copy Markdown
Contributor

@rrs rrs commented Jul 14, 2021

A lot of the demo project still needs expanding to include the secondary variants in place of the old accent variants, this is a start on that focusing on buttons.
I have also added a new variant 'Paper' buttons, they are a cross between raised and flat buttons, but at this point they explicitly use the paper and body colors, rather than transparent, my reason for this is they will still look appropriate with the theme but always stay dark or light. I find the normal buttons too overpowering and flat buttons too inconspicuous, and suspect others might like these too. I use a color zone on the test project to show them off.

I also added a toggle to disable or enable all the buttons to see what they look like

paperbuttons

@rrs rrs changed the title Expand Buttons Test App to Include Secondary Variants + New 'Paper' Button Expand Demo to Include Secondary Variants for Buttons + New 'Paper' Button Jul 14, 2021
@Keboo Keboo added the demo app Items that relate to the demo application label Jul 16, 2021
@Keboo Keboo added this to the 4.2.0 milestone Jul 16, 2021
<materialDesign:ColorZone Margin="0 24 0 0" Mode="{Binding SelectedItem, ElementName=ColorZoneMode}">
<StackPanel>
<DockPanel>
<ComboBox DockPanel.Dock="Right" Name="ColorZoneMode" HorizontalAlignment="Center" VerticalAlignment="Center" MinWidth="120" ItemsSource="{Binding Source={StaticResource ColorZoneModes}}" SelectedIndex="0" />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how much value this adds since in most cases you just need to test dark and light theme. This is already an option from the three dots menu in the top right.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion on leaving it in, it was more to show how the paper variant responds to being on the colored backgrounds, which granted, is probably not a common use case really

<TextBlock
Style="{StaticResource MaterialDesignHeadline5TextBlock}"
Text="Buttons"/>
<ToggleButton x:Name="ButtonsEnabled"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the addition of this! I do wonder if more areas could benefit from this, and if so if it would be good to move it up under the menu in the top right next to the dark/light theme toggle.

@rrs
Copy link
Copy Markdown
Contributor Author

rrs commented Jul 16, 2021

paperbuttons2

@rrs
Copy link
Copy Markdown
Contributor Author

rrs commented Jul 17, 2021

p.s. let me know your thoughts on the 'paper' themed controls, I'm working on doing some of the others too

@Keboo Keboo added enhancement release notes Items are likely to be highlighted in the release notes. labels Jul 17, 2021
@Keboo Keboo merged commit addbb34 into MaterialDesignInXAML:master Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

demo app Items that relate to the demo application enhancement release notes Items are likely to be highlighted in the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants